routerclient: add payment request route fee estimates#273
Merged
Conversation
Contributor
|
EstimateRouteFeeWithRequest is oneof (old EstimateRouteFee , PaymentRequest + Timeout). Wouldn't it be better to add another method for the PaymentRequest + Timeout variant and avoid EstimateRouteFee deprecation? Given the new method is split between these two variants anyway. |
|
@starius: review reminder |
hieblmi
force-pushed
the
upgrade-estimate-route-fee
branch
from
7271891 to
b1dfe55
Compare
hieblmi
changed the title
EstimateRouteFeeWithRequest and deprecate EstimateRouteFee
hieblmi
force-pushed
the
upgrade-estimate-route-fee
branch
from
b1dfe55 to
767763e
Compare
Contributor
Author
|
Thanks @starius, this makes sense. I created which is called by old and new method. |
starius
approved these changes
Jun 10, 2026
starius
left a comment
starius
left a comment
Contributor
There was a problem hiding this comment.
LGTM! 🎉
I have one naming proposal and also found some small issues.
hieblmi
force-pushed
the
upgrade-estimate-route-fee
branch
from
767763e to
62beb9f
Compare
hieblmi
force-pushed
the
upgrade-estimate-route-fee
branch
from
62beb9f to
bde6490
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EstimateRouteFeeWithPaymentRequestfor payment-request probing through LND'sEstimateRouteFeeRPC:PaymentRequestTimeoutEstimateRouteFeeResponseso callers can accessRoutingFee,TimeLockDelay, andFailureReasonfor probe estimates.EstimateRouteFee(ctx, dest, amt)method as the graph-based route-fee API without deprecating it./routerrpc.Router/EstimateRouteFeepermission.